Optimizing By Using Precomputed Set of Partitions in DatastreamMetadata #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoomula
approved these changes
Oct 5, 2023
| @@ -91,7 +91,7 @@ public Map<String, Set<DatastreamTask>> assignPartitions( | |||
| tasks.forEach(task -> { | |||
| if (task.getTaskPrefix().equals(datastreamGroupName)) { | |||
| Set<String> retainedPartitions = new HashSet<>(task.getPartitionsV2()); | |||
| retainedPartitions.retainAll(new HashSet<>(partitionMetadata.getPartitions())); | |||
| retainedPartitions.retainAll(partitionMetadata.getPartitions()); | |||
There was a problem hiding this comment.
Is partitionMetadata.getPartitions() used only in the below three places ?
There was a problem hiding this comment.
Its used in other places as well but some basic operations on list and set are common, hence no change needed there.
hshukla
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md