Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements for assignment tokens feature #941

Merged
merged 3 commits into from
May 31, 2023

Conversation

jzakaryan
Copy link
Collaborator

  • Improved logging for when the coordinator fails to check if the connector tasks have stopped (earlier uncaught exceptions in this path would result in the token claim thread silently dying and a false alert firing)
  • If there are no stopping streams, no task will be spun off to check for stop propagation. This was taking up a thread from the thread pool for no reason.
  • Clearly marked the start and end of waitForStopToPropagateAndMarkDatastreamsStopped. Removed redundant message
  • Added a confirmation message for when the leader transitions a stream to the STOPPED state.

Things that are NOT part of this PR:

  • Separation of the thread pools for leader's tasks to wait for stop propagation and for followers tasks to claim tokens.
  • Printing how much time it took the leader to mark a stream STOPPED (this is not a trivial change and will be evaluated/addressed separately)

@jzakaryan jzakaryan merged commit 2238d82 into master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants