Add metrics for CoordinatorEvent queue #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzakaryan
previously approved these changes
May 25, 2023
...tream-server/src/main/java/com/linkedin/datastream/server/CoordinatorEventBlockingQueue.java
Outdated
Show resolved
Hide resolved
...tream-server/src/main/java/com/linkedin/datastream/server/CoordinatorEventBlockingQueue.java
Show resolved
Hide resolved
jzakaryan
approved these changes
May 30, 2023
shrinandthakkar
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
GaugeandCountertoCoordinatorEventBlockingQueue. TheGaugetracks the current size of the underlying queue; and theCounterincrements when a duplicate event isput(). The class implementsMetricsAwareand registers the underlying metrics to the simple class name + constructor parameterkey. The existing parameterless constructor is marked deprecated. It registers metrics to the key "CoordinatorEventBlockingQueue.legacy".The change to
MetricTestUtilswas required to avoid collisions withTestCoordinator. ThestartsWithpredicate was changed tomatchto ensure that the entire name was used to filter. The same metric verification registration test was added to theCoordinatorEventBlockingQueue.