Add retry to query retention time for destination topic #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaheshw
reviewed
Nov 8, 2021
datastream-kafka/src/main/java/com/linkedin/datastream/kafka/KafkaTransportProviderAdmin.java
Show resolved
Hide resolved
Since migrating to AdminClient to create destination topic it was observed that sometimes there is a lag in topic metadata to be synced to all brokers. This may result in getting incorrect (null) retention time. Adding a retry logic to account for delay in topic metadata sync.
surajkn
force-pushed
the
retry_get_retention
branch
from
e64cce2
to
f421d85
Compare
vmaheshw
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since migrating to AdminClient to create destination topic it was observed that sometimes there is a
lag in topic metadata to be synced to all brokers. This may result in getting incorrect (null)
retention time. Adding a retry logic to account for delay in topic metadata sync.
Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md