Fixing flaky test testCreateDatastreamHappyPathDefaultRetention

[surajkn]

Increasing the timeout before validating retention time.

Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.

Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md

[shrinandthakkar]

After today's discussion, would we be merging this code? Or are we waiting on the Kafka team to get a solution instead of having a timer?

[surajkn]

Shrinand, I will be merging this for now to make the test better for now. I will be following this up with another patch to fix the issue, but want to check in this patch to resolve the CircleCI build failing (fairly) consistently.

The follow up patch will basically be adding a exponential backoff retry mechanism with a upper time bound close to the config sync time SLA. Which I am expecting to get idea from Kafka team on how to estimate it.

[shrinandthakkar]

Shrinand, I will be merging this for now to make the test better for now. I will be following this up with another patch to fix the issue, but want to check in this patch to resolve the CircleCI build failing (fairly) consistently.

The follow up patch will basically be adding a exponential backoff retry mechanism with a upper time bound close to the config sync time SLA. Which I am expecting to get idea from Kafka team on how to estimate it.

gotcha! lgtm!