Fix flaky test testConsumeFromMultipleTopics #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull latest
vmaheshw
requested review from
somandal,
atoomula,
jzakaryan and
shrinandthakkar
somandal
approved these changes
Jun 18, 2021
vmaheshw
added a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
Fix flaky test testConsumeFromMultipleTopics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle suite > Gradle test > com.linkedin.datastream.connectors.kafka.mirrormaker.TestKafkaMirrorMakerConnectorTask.testConsumeFromMultipleTopics FAILED java.lang.AssertionError: Metric KafkaMirrorMakerConnector.cff18360-e356-48eb-89e0-aa1d07d125d4.numPartitionFetchErrors must match exactly one BrooklinMetricInfo but it matched 0 expected [1] but found [0] at org.testng.Assert.fail(Assert.java:97) at org.testng.Assert.assertEqualsImpl(Assert.java:136) at org.testng.Assert.assertEquals(Assert.java:118) at org.testng.Assert.assertEquals(Assert.java:839) at com.linkedin.datastream.testutil.MetricsTestUtils.verifyMetrics(MetricsTestUtils.java:100) at com.linkedin.datastream.testutil.MetricsTestUtils.verifyMetrics(MetricsTestUtils.java:56) at com.linkedin.datastream.connectors.kafka.mirrormaker.TestKafkaMirrorMakerConnectorTask.testConsumeFromMultipleTopics(TestKafkaMirrorMakerConnectorTask.java:144)This test failing because of another test in AbstractKafkaConnector running at the same time hits "Error in PartitionDiscoveryThread` which results in additional metric registration. In the flaky test, the filter is missing and it finds additional metric and fails.
To fix this, adding the connector filter to only check for relevant metrics.