-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace vello's default wgpu
feature with an optional wgpu
feature
#10
Conversation
Can you explain why we wouldn't want the default feature for |
So that crates using |
Ah, I see. We actually don't need the wgpu feature at all, I think. Since this crate only renders a |
Please update the CHANGELOG in turn and I can approve this. Thanks! |
Yes, I could have spent a few more words explaining that Before pushing an updated changelog: since this crate reexports |
Yeah, let's do that. |
4f23ebe
to
28fe7c4
Compare
vello
to remove wgpu
wgpu
feature with an optional vello-wgpu
feature
@simbleau done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change that feature name to just wgpu
.
…ature linebender/vello#359 made `wgpu` an optional but default dependency/feature, but any crate using `vello_svg` will be forced to opt in to `wgpu` due to not disabling the default here. Since `vello_svg` does not need any rendering backend at all, this feature should be disabled by default. As the `vello` crate is reexported from the root, a `wgpu` passthrough feature is provided so that users can turn it back on without explicitly depending on `vello` in their crate dependencies.
28fe7c4
to
4264bd7
Compare
Thanks! |
wgpu
feature with an optional vello-wgpu
featurewgpu
feature with an optional wgpu
feature
linebender/vello#359 made
wgpu
an optional but default dependency/feature, but any crate usingvello_svg
will be forced to opt in towgpu
due to not disabling the default here.Since
vello_svg
does not need any rendering backend at all, this feature should be disabled by default. As thevello
crate is reexported from the root, avello-wgpu
passthrough feature is provided so that users can turn it back on without explicitly depending onvello
in their crate dependencies.Same change as linebender/velato#17.