Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use Linebender standard CI. Add Cargo.lock. #357

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Aug 2, 2024

This is copied from Peniko with minor adjustments:

  • RUST_STABLE_VER is 1.79 as Kurbo needs fixes for 1.80.
  • RUST_MIN_VER is 1.65.
  • RUST_MIN_VER_PKGS checks kurbo.
  • FEATURES_DEPENDING_ON_STD added schemars.
  • Change the authors check in the copyright step.
  • Changes to handle not saving the cache when doing a merge_group.
    These come from Vello.

The dependencies are all updated to their current versions and a Cargo.lock is now used in accordance with other Linebender projects.

@waywardmonkeys
Copy link
Contributor Author

@xStrom @DJMcNab This will need administrative assistance because the CI checks are changing.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no other Kurbo maintainers we need to involve with this, happy for it to land.

Once you're sure this is ready to go in, I'll make the config changes.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
This is copied from Peniko with minor adjustments:
* `RUST_STABLE_VER` is 1.79 as Kurbo needs fixes for 1.80.
* `RUST_MIN_VER` is 1.65.
* `RUST_MIN_VER_PKGS` checks `kurbo`.
* `FEATURES_DEPENDING_ON_STD` added `schemars`.
* Change the authors check in the copyright step.
* Changes to handle not saving the cache when doing a merge_group.
  These come from Vello.

The dependencies are all updated to their current versions
and a `Cargo.lock` is now used in accordance with other
Linebender projects.
@waywardmonkeys
Copy link
Contributor Author

@DJMcNab I think this is good to go now and if you want to squash and then go, that's great.

@DJMcNab DJMcNab added this pull request to the merge queue Aug 2, 2024
Merged via the queue into linebender:main with commit f512d6e Aug 2, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the update-ci branch August 2, 2024 08:50
@waywardmonkeys waywardmonkeys added this to the August, 2024 Release milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants