-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add triangle shape #350
Open
juliapaci
wants to merge
23
commits into
linebender:main
Choose a base branch
from
juliapaci:triangle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+341
−0
Open
add triangle shape #350
Changes from 5 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d8fc124
init
juliapaci 0878d60
chore: format
juliapaci c5b255e
path iterator
juliapaci 8bfd8f4
extend api
juliapaci 8403950
fix ci
juliapaci a8360f0
TODO completion progress
juliapaci be6ed8d
tests
juliapaci a2527bc
bug fixes
juliapaci 8b03193
working `organise`\(\)
juliapaci e40449c
proper ellipse size
juliapaci 30d9e1c
fix ci
juliapaci 5580aef
chore: format
juliapaci 4d8f906
apply suggestions
juliapaci 0438fae
tests
juliapaci 7d1e41d
apply cleanup suggestions
juliapaci 8bac853
signed area test
juliapaci 8da1a8c
match new style
juliapaci b2f4739
add `is_zero_area` doc alias
juliapaci 57b4cb0
remove from `Line`
juliapaci 4f17103
Apply explicit suggestions from derekdreery
juliapaci 4d0afb9
remove point comparisons
juliapaci 3da32b7
apply implicit suggestions
juliapaci 4823cb3
meta cleanup
juliapaci File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is justified.
Perhaps there should be
incircle
andcircumcircle
methods on Triangle; I'd be open to that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you're right