Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHANGELOG.md #349

Merged
merged 2 commits into from
May 30, 2024
Merged

Add CHANGELOG.md #349

merged 2 commits into from
May 30, 2024

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

derekdreery
derekdreery reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@derekdreery derekdreery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to have a changelog (which I think is a good idea) we should have a note on the README.md asking contributors to add a note to the changelog as part of their PR.

derekdreery
derekdreery approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@derekdreery derekdreery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed in office hours and decided to have changelog, and that we are aiming to have it for all linebender projects.

xStrom
xStrom approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the grander scheme of things we want to have even better changelogs and a whole workflow on how they get continuously maintained. However none of that needs to happen in this PR.

Thanks for taking this step and getting us going!

@waywardmonkeys
Copy link
Contributor Author

@xStrom Should I rebase, squash or merge commit? :)

@derekdreery
Copy link
Collaborator

@xStrom Should I rebase, squash or merge commit? :)

Good question - IIRC we talked about it and prefer squash commits, but I may be wrong. I don't think it matters too much.

@xStrom
Copy link
Member

xStrom commented May 30, 2024

Squash, merge queues will arrive sometime in the future. 😆

@waywardmonkeys waywardmonkeys merged commit 1cbf3c0 into linebender:main May 30, 2024
14 checks passed
@waywardmonkeys waywardmonkeys deleted the add-changelog branch May 30, 2024 16:02
@waywardmonkeys waywardmonkeys added this to the August, 2024 Release milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xStrom xStrom xStrom approved these changes

@derekdreery derekdreery derekdreery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.
3 participants
@waywardmonkeys @derekdreery @xStrom