Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing bounds on CircleSegment #322

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Add missing bounds on CircleSegment #322

merged 1 commit into from
Dec 7, 2023

Conversation

ratmice
Copy link
Contributor

@ratmice ratmice commented Nov 7, 2023

Besides CircleSegment all the other structures implementing Shape also derive the traits (added), some also
derive Default, such as Circle. I didn't add a Default implementation however.

@ratmice ratmice merged commit 4da6fa9 into linebender:main Dec 7, 2023
14 checks passed
@ratmice ratmice deleted the missing_bounds branch December 7, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneem jneem jneem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ratmice @jneem