Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'save as' dialog, tweak open/save API #376

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Implement 'save as' dialog, tweak open/save API #376

merged 1 commit into from
Dec 4, 2019

Commits on Dec 3, 2019

  1. Implement 'save as' dialog, tweak open/save API

    This gets the 'save as' dialog working in a similar fashion to
    the 'open' dialog.
    
    The API isn't great. In druid-shell, open and save_as are exposed
    as two different methods on WinCtx. They could be unified, now,
    at the cost of a slightly less ergonomic API; the caller would
    have to bring the FileDialogType enum into scope and pass it
    directly.
    
    In druid, the API is also slightly different. The Event::Open variant
    has been removed, and both open and save are now fully Command based.
    
    The basic idea is that there are two 'special' commands,
    SHOW_SAVE_PANEL and SHOW_OPEN_PANEL, that are handled by the framework.
    When these commands are received, the framework handles showing the
    appropriate panel, and getting the input. If this succeeds,
    the framework then sends either the SAVE_FILE or OPEN_FILE command,
    which is expected to be handled by the framework author.
    cmyr committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    1c5dab7 View commit details
    Browse the repository at this point in the history