Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

Bookstore: styling #5

Merged
merged 9 commits into from
Aug 3, 2023
Merged

Bookstore: styling #5

merged 9 commits into from
Aug 3, 2023

Conversation

lily4178993
Copy link
Owner

Bookstore: styling

Changes implemented

This PR is raised according to this requirements. The following changes have been done:

  • Delete unused files
  • Use CSS rules for the final design detailed in Zeplin
  • Add media querries for tablet and mobile screens

How should this app be tested?

Clone this repository:

git clone https://github.com/lily4178993/my-book-store.git

Checkout the branch:

cd my-book-store
git checkout features-styling

Install all dependencies:

npm install

Fix JS/JSX linter error

npx eslint "**/*.{js,jsx}" --fix

Open the project:

npm run start

Please kindly review our implementation and suggest any changes and improvements. 
Best regards.
Thanks for reviewing this PR 😊

Copy link

@AbelG101 AbelG101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lily4178993 👋,

You're doing a good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • UI is looking good ✔
  • Proper modular styling approach ✔
  • Correct use of Git Flow ✔
  • Well-structured files ✔
  • All linter checks are passing ✔
  • Descriptive PR title with a great summary ✔

Required Changes ♻️

  • Check the comments under the review.
  • you just have to make a few changes and you're on your way 🚀.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

You can also consider:

  • N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

src/components/styles/Header.module.css Outdated Show resolved Hide resolved
src/components/styles/Books.module.css Outdated Show resolved Hide resolved
src/components/styles/BooksCard.module.css Show resolved Hide resolved
src/components/styles/BooksCard.module.css Show resolved Hide resolved
@lily4178993
Copy link
Owner Author

Thank you @AbelG101 for taking the time to review this banch.

@lily4178993
Copy link
Owner Author

I have updated the project UI as requested by the previous reviewer:

  • Add border to header
  • Increase book card width
  • Fix google fonts import
  • Remove repeating CSS properties

Please kindly review our implementation and suggest any changes and improvements.

Best regards.

Copy link

@IngDavidTM IngDavidTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lily4178993 🙋‍♂️,

✔️ Status: APPROVED 🏆 🎉 🎊

You have done a great job on this project, keep it up 👍 🥇. Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉💯🌟

Top highlight 🎯

  • The Pull Request follows the GitFlow ✅
  • The PR title and description are professional and descriptive ✅
  • Linters are working properly ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@lily4178993
Copy link
Owner Author

Thank you @IngDavidTM for taking the time to review this branch.

@lily4178993 lily4178993 merged commit 895a6ff into dev Aug 3, 2023
3 checks passed
@lily4178993 lily4178993 deleted the features-styling branch August 3, 2023 16:41
Repository owner locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants