Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

Bookstore: connect to API #4

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Bookstore: connect to API #4

merged 7 commits into from
Aug 2, 2023

Conversation

lily4178993
Copy link
Owner

Bookstore: connect to API

Description

In this step I connected this application to an existing API to create and remove books from a server.

Changes implemented

This PR is raised according to this requirements. The following changes have been done:

  • Use axios with createAsyncThunk to make HTTP requests to the backend
  • Fetch the books from the API after the component has rendered
  • Refactor the add book and remove book features to persist the changes in the server

How should this app be tested?

Clone this repository:

git clone https://github.com/lily4178993/my-book-store.git

Checkout the branch:

cd my-book-store
git checkout features-api

Install all dependencies:

npm install

Fix JS/JSX linter error

npx eslint "**/*.{js,jsx}" --fix

Open the project:

npm run start

Please kindly review our implementation and suggest any changes and improvements. 
Best regards.
Thanks for reviewing this PR 😊

Copy link

@elisha2kyakpo1 elisha2kyakpo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋 @lily4178993,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

✔️ The PR title and description are good and professional.
✔️ No linter errors.
✔️ Descriptive readme file.
✔️ API calls done (Add and remove)👏
👏 The app works as expected.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@lily4178993
Copy link
Owner Author

Thank you @elisha2kyakpo1 for taking the time to review this branch. Have a great day!

@lily4178993 lily4178993 merged commit 09693c6 into dev Aug 2, 2023
3 checks passed
@lily4178993 lily4178993 deleted the features-api branch August 2, 2023 14:19
Repository owner locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants