-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STATUS: APPROVED ✔️ 🍾 🍾 🍾 🥳 🥳 🥳
Hi @lily4178993,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
✅ All linters checks are ok
✅ The correct workflow is used.
✅ Very descriptive Pull Request(PR)
✅ Your work is well documented.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Thank you @bobb-Rob for taking the time to review this branch. |
Bookstore: Redux in React components
Description
In this step I used a Redux store to display books. I implemented
react-redux
in order to connect the store and then access thestate variables (accessed throughuseSelector
) and state modifiers (which will be a combination of areducer
anduseDispatch
).Changes implemented
This PR is raised according to this requirements. The following changes have been done:
<App>
with the<Provider>
component fromreact-redux
store
into the<Provider>
initialState
variable for thebooksSlice
, which will include the following:books
, received from the slice, in a reusable componentuseDispatch
<Button>
component, which includes:books
array (with attributes id, title and author)<Button>
component, which includes:books
array (by id)Please kindly review our implementation and suggest any changes and improvements. Best regards.
Thanks for reviewing this PR 😊