use pyproject.toml to force old setuptools for build #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This minimally address #79 , however, I'd consider this a hack until dqsegdb can run on python3 without p2to3 in setuptools (maybe it can already?). |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 11.99% 11.99%
=======================================
Files 5 5
Lines 1017 1017
=======================================
Hits 122 122
Misses 895 895
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
robertbruntz
changed the title
|
This PR is no longer necessary, since #81 fixed the use_2to3 issue (by setting it to False). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.