Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header menu responsive bugs #47

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Header menu responsive bugs #47

merged 2 commits into from
Sep 11, 2023

Conversation

Justinabes007
Copy link
Contributor

Description of the Change

  • Responsive issues in Header
  • Menu displays Full Page list, which doesn't display well on first install.
  • Logo display made larger and removed site title
  • Tablet Break Menu displays long and also causes display issues, included styling to display mobile menu on screens 899px and less.

Verification Process

  • Tested all elements locally, fresh new install, with import content.

Changelog Entry

  • Header.html
  • style.css

@Justinabes007
Update to header.html
c482e18 
Size logo
Remove site title
Remove Page list and have basic menu as per Course
@Justinabes007
Update to style.css
e58ebdb 
Adjusting breakpoints from 899px size.
@Justinabes007 Justinabes007 added this to the 1.2.0 milestone Sep 8, 2023
@Justinabes007 Justinabes007 self-assigned this Sep 8, 2023
@Justinabes007 Justinabes007 linked an issue Sep 8, 2023 that may be closed by this pull request
Header & Menu responsive bugs #46
Closed
@krugazul
Copy link
Contributor

@Justinabes007 I have tested these locally, they are working as expected.

@krugazul krugazul merged commit 2f51612 into main Sep 11, 2023
3 of 4 checks passed
@krugazul krugazul deleted the header-menu-responsive-bugs branch September 11, 2023 12:49
@krugazul krugazul mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krugazul krugazul Awaiting requested review from krugazul

Assignees

@Justinabes007 Justinabes007

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Header & Menu responsive bugs
2 participants
@Justinabes007 @krugazul