Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP 6.6 Grid Block - Image cover display issues & theme compatibility #135

Closed
Justinabes007 opened this issue Jul 12, 2024 · 1 comment · Fixed by #149
Closed

WP 6.6 Grid Block - Image cover display issues & theme compatibility #135

Justinabes007 opened this issue Jul 12, 2024 · 1 comment · Fixed by #149
Assignees
@Justinabes007
Labels
Needs Dev Anything that needs development. Needs Testing Issues that need to be tested and confirmed. [Type] Bug Something isn't working
Milestone
1.4

Comments

@Justinabes007
Copy link
Contributor

Grid Block Compatibility issues
With the new version of WordPress and the introduction to Grid block for improved layout and full-width layouts, we have encountered some core or theme compatibility issues.

Images:

Images within the Grid block don't display the same in the Editor vs front end.

Editor View - Images cover correctly
Screenshot 2024-07-12 at 11 49 55

Front end View - Images don't cover correctly
Screenshot 2024-07-12 at 11 49 43
@Justinabes007 Justinabes007 added Needs Dev Anything that needs development. Needs Testing Issues that need to be tested and confirmed. [Type] Bug Something isn't working labels Jul 12, 2024
@Justinabes007 Justinabes007 added this to the 1.4 milestone Jul 12, 2024
@Justinabes007 Justinabes007 self-assigned this Jul 12, 2024
Justinabes007 added a commit that referenced this issue Jul 26, 2024
@Justinabes007
Grid Compatibility
eb17db0 
Include Wp 6.6 Grid Block compatibility with theme.

Close #137
Close #135
@Justinabes007
Copy link
Contributor Author

CSS Improvements were added for Better Grid Block functionality with Image Blocks & Group Blocks.
Commit of CSS - eb17db0

Demo of the solution can be found here - https://demo.lsx.design/test/
Screenshot below:
Screenshot 2024-07-26 at 12 42 35

@Justinabes007 Justinabes007 mentioned this issue Jul 26, 2024
Merged
@krugazul krugazul linked a pull request Jul 29, 2024 that will close this issue
WP 6.6 Grid Block compatibility with theme #149
Merged
@krugazul krugazul mentioned this issue Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Justinabes007 Justinabes007

Labels
Needs Dev Anything that needs development. Needs Testing Issues that need to be tested and confirmed. [Type] Bug Something isn't working
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

WP 6.6 Grid Block compatibility with theme lightspeedwp/lsx-design
2 participants
@krugazul @Justinabes007