Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapcli: add --show_leased flag to assets list subcommand #1039

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Jul 22, 2024

Fixes #1038.

Adds the missing --show_leased flag to the tapcli assets list subcommand.

@guggero guggero self-assigned this Jul 22, 2024
@guggero guggero added this to the v0.4.1 milestone Jul 22, 2024
@guggero guggero requested review from jharveyb and ffranr July 23, 2024 14:13
Copy link
Collaborator

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛖

@Roasbeef Roasbeef added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit eae7b55 Jul 23, 2024
16 checks passed
@guggero guggero deleted the tapcli-show-leased branch July 24, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[bug]: FundChannel Ack Timeout Issue
3 participants