Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace np.float_ by np.float64 (support numpy 2) #1561

Merged

Conversation

philippmwirth
Copy link
Contributor

@philippmwirth philippmwirth commented Jun 20, 2024

Replace np.float_ by np.float64 (support numpy 2)

Part of #1558. I'm following the migration guide.

  • Replace np.float_ by np.float64.

@philippmwirth philippmwirth changed the title Use np.float_ over np.float64 Migrate to numpy 2 Jun 20, 2024
@philippmwirth philippmwirth mentioned this pull request Jun 22, 2024
@philippmwirth philippmwirth reopened this Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (ffe5b56) to head (bd67292).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1561   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files         144      144           
  Lines        6119     6119           
=======================================
  Hits         5006     5006           
  Misses       1113     1113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippmwirth philippmwirth changed the title Migrate to numpy 2 Migrate codebase to numpy 2 Jun 24, 2024
Copy link
Contributor

@MalteEbner MalteEbner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace np.Inf by np.inf

I don't see any change regarding this. Did you do it in another PR?

Otherwise, I would approve.

@philippmwirth philippmwirth changed the title Migrate codebase to numpy 2 Replace np.float_ by np.float64 (support numpy 2) Jun 24, 2024
@philippmwirth philippmwirth merged commit f9e353c into master Jun 24, 2024
10 checks passed
@philippmwirth philippmwirth deleted the philipp-lig-5148-lightlyssl-support-or-disable-numpy-20 branch June 24, 2024 14:29
@adamjstewart adamjstewart mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants