Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@libp2p/crypto): improve unsupported key type message #2051

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix(@libp2p/crypto): improve unsupported key type message #2051

merged 2 commits into from
Sep 15, 2023

Commits on Sep 14, 2023

  1. fix(@libp2p/crypto): improve unsupported key type message 

    When an unsupported key type is encountered, but the type is actually missing from the protobuf, don't default the key type in the thrown error to `RSA` because it's not an RSA key, doing so is leads to confusing messages like:

```
invalid or unsupported key type RSA. Must be rsa / ed25519 / secp256k1
```

Instead say that the key type is unknown.
    @achingbrain
    achingbrain authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    d6e6ef5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/unsupported-key-type-message

    @maschad
    maschad authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    0e37613 View commit details
    Browse the repository at this point in the history