fix(@libp2p/crypto): improve unsupported key type message #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an unsupported key type is encountered, but the type is actually missing from the protobuf, don't default the key type in the thrown error to `RSA` because it's not an RSA key, doing so is leads to confusing messages like: ``` invalid or unsupported key type RSA. Must be rsa / ed25519 / secp256k1 ``` Instead say that the key type is unknown.
maschad
approved these changes
Sep 14, 2023
SgtPooki
approved these changes
Sep 14, 2023
maschad
added a commit
to maschad/js-libp2p
that referenced
this pull request
Sep 27, 2023
When an unsupported key type is encountered, but the type is actually missing from the protobuf, don't default the key type in the thrown error to `RSA` because it's not an RSA key, doing so is leads to confusing messages like: ``` invalid or unsupported key type RSA. Must be rsa / ed25519 / secp256k1 ``` Instead say that the key type is unknown. Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an unsupported key type is encountered, but the type is actually missing from the protobuf, don't default the key type in the thrown error to
RSAbecause it's not an RSA key, doing so leads to confusing messages like:Instead say that the key type is unknown.