don't disconnect on protocol version mismatch #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending a protocol version is nice. However, this "disconnect if our versions are different" logic makes the version entirely useless (because we can't change it). Really, each indevidual protocol is versioned so let's just leave it at that. If we make a breaking change that requires a protocol bump, we can do that and then switch on the other side's version. However, we'll have to wait for the entire network to upgrade for that to work.
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending a protocol version is nice. However, this "disconnect if our versions are different" logic makes the version entirely useless (because we can't change it).
Really, each indevidual protocol is versioned so let's just leave it at that. If we make a breaking change that requires a protocol bump, we can do that and then switch on the other side's version. However, we'll have to wait for the entire network to upgrade for that to work.