Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify: consider dropping the protocol version #2294

Closed
p-shahi opened this issue May 15, 2023 · 4 comments · Fixed by #2303
Closed

identify: consider dropping the protocol version #2294

p-shahi opened this issue May 15, 2023 · 4 comments · Fixed by #2303

Comments

@p-shahi
Copy link
Member

p-shahi commented May 15, 2023

Go through old kubo and libp2p versions that implemented the identify protocol versions, cross reference in probelabs to see which are still in use, and see if we can drop the /ipfs/0.1.0 protocol version altogether

@mxinden
Copy link
Member

mxinden commented May 16, 2023

For what it is worth, I can not find a version of rust-libp2p that ever supported /ipfs/0.1.0. Already since libp2p/rust-libp2p#116 rust-libp2p uses /ipfs/id/1.0.0.

@marten-seemann
Copy link
Contributor

This was dropped in #461, almost 5 years ago. This should be safe to remove now.

@marten-seemann
Copy link
Contributor

@achingbrain Would this change break compatibility with js-libp2p versions?

@achingbrain
Copy link
Member

It should be fine - js-libp2p only uses the protocol version field as peer metadata and doesn't act on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants