Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basichost: refactor BasicHost construction #197

Merged
merged 1 commit into from
May 31, 2017

Commits on May 31, 2017

  1. basichost: refactor BasicHost construction

    There were previously 4 different ways of passing various options
    into BasicHost construction.
    
    1. Function parameters to New
    2. Option parameters to New
    3. Global variables, e.g. NegotiateTimeout
    4. Options struct, in the calling code in go-ipfs
    
    This changeset deprecated all of these, and introduces the HostOpts
    struct to replace them. It also introduces a new constructor called
    NewHost, which accepts a *HostOpts.
    
    The old New constructor continues to work the same way,
    but is from now on deprecated too.
    Lars Gierth committed May 31, 2017
    Configuration menu
    Copy the full SHA
    f0453a2 View commit details
    Browse the repository at this point in the history