basichost: refactor BasicHost construction #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I shall add some tests for NewHost while I'm at it... |
There were previously 4 different ways of passing various options into BasicHost construction. 1. Function parameters to New 2. Option parameters to New 3. Global variables, e.g. NegotiateTimeout 4. Options struct, in the calling code in go-ipfs This changeset deprecated all of these, and introduces the HostOpts struct to replace them. It also introduces a new constructor called NewHost, which accepts a *HostOpts. The old New constructor continues to work the same way, but is from now on deprecated too.
ghost
force-pushed
the
feat/refactor-basichost-new
branch
from
39ebca7
to
f0453a2
Compare
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were previously 4 different ways of passing various options
into BasicHost construction.
This changeset deprecates all of these, and introduces the HostOpts
struct to replace them. It also introduces a new constructor called
NewHost, which accepts a *HostOpts.
The old New constructor continues to work the same way,
but is from now on deprecated too.