add an integration test for muxer selection #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi I moved the base to |
MarcoPolo
approved these changes
Nov 16, 2022
| @@ -182,6 +182,7 @@ func (cfg *Config) addTransports(h host.Host) error { | |||
| fx.ParamTags(`group:"security"`), | |||
| )), | |||
| fx.Supply(cfg.Muxers), | |||
| fx.Supply(h.ID()), | |||
There was a problem hiding this comment.
Why this change? Did this not work before?
There was a problem hiding this comment.
The insecure transport consume the peer.ID:
go-libp2p/core/sec/insecure/insecure.go
Line 43 in d8d2efa
The other transports consume the private key.
marten-seemann
force-pushed
the
remove-muxer-multistream
branch
from
96ccea1
to
167ad7d
Compare
This is needed to construct the insecure transport.
marten-seemann
force-pushed
the
muxer-integration-test
branch
from
b36079e
to
4b74c65
Compare
marten-seemann
changed the base branch from
remove-muxer-multistream
to
master
|
Rebased and changed merge target back to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1836. Depends on #1885. Closes #1851. Closes #1840.
The test currently fails since apparently the early muxer negotiation respects the server's preferences, not the client's. We should fix that. Will do in another PR.