Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create integration test for libp2p early muxer negotiation #1836

Closed
Tracked by #1789
julian88110 opened this issue Oct 21, 2022 · 1 comment · Fixed by #1887
Closed
Tracked by #1789

Create integration test for libp2p early muxer negotiation #1836

julian88110 opened this issue Oct 21, 2022 · 1 comment · Fixed by #1887
Assignees
@julian88110

Comments

@julian88110
Copy link
Contributor

julian88110 commented Oct 21, 2022 •
edited
Loading

The code changes that are specified in #446 changes muxer negotiation behavior, an integration test plan should be put in place to test the correct muxer negotiation behavior.
@julian88110 julian88110 self-assigned this Oct 21, 2022
@marten-seemann
Copy link
Contributor

Specifically, we should test that if the client has muxer preference a > b and the server has muxer preference b < a, TLS, Noise and multistream negotiate the same muxer.

This was referenced Oct 23, 2022
Closed
Closed
@p-shahi p-shahi mentioned this issue Nov 7, 2022
Closed
@p-shahi p-shahi linked a pull request Nov 7, 2022 that will close this issue
Muxer early negotiation integration test #1840
Closed
@marten-seemann marten-seemann mentioned this issue Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julian88110 julian88110

Labels
None yet
Projects
go-libp2p
Archived in project
Milestone
No milestone
2 participants
@marten-seemann @julian88110