Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move go-ws-transport here #1422

Merged
merged 124 commits into from
Apr 22, 2022
Merged

move go-ws-transport here #1422

merged 124 commits into from
Apr 22, 2022

Conversation

marten-seemann
Copy link
Contributor

Part of #1187.

whyrusleeping and others added 30 commits May 16, 2016 12:29
This fixes websocket interop with js-ipfs
fix: use binary frames instead of text frames
feat: upgrade to use gorilla/websocket
fix reading from conn and addresses
1. Ensure we only close the connection once. Especially, don't call the done
function multiple times and/or concurrently.
2. Call WriteControl instead of WriteMessage in Close. WriteControl is
thread-safe, WriteMessage isn't.

Also, this sets a 100ms deadline on gracefully closing connections.
Just to be thorough.
Stebalien and others added 24 commits July 15, 2021 10:17
sync: update CI config files
chore: update go-libp2p-transport-upgrader and go-libp2p-core
use the transport.Upgrader interface
use the resource manager
add support for listening on /wss addresses
@marten-seemann marten-seemann mentioned this pull request Apr 22, 2022
65 tasks
Comment on lines +26 to +27
csms "github.com/libp2p/go-conn-security-multistream"
mplex "github.com/libp2p/go-libp2p-mplex"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably wait for these to be moved first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? go-libp2p depending on external repos is ok (the other way around would not).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but we'll have to remember to fix it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. I do a sed for the import path every time I move a repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, fair enough.

@marten-seemann marten-seemann merged commit 7d50e43 into master Apr 22, 2022
@marten-seemann marten-seemann deleted the merge-websocket branch April 22, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants