don't block on DiscoverHandler #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbenet
suggested changes
Sep 20, 2016
| for entry := range entriesCh { | ||
| m.handleEntry(entry) | ||
| } | ||
| }() |
There was a problem hiding this comment.
this is incorrect-- how does it pass tests?
this chan creation and goroutine is here because there may be mdns.Query errors for a single peer. the way you moved it out to the top of pollForEntries will make it so that it will close the chan exit after the first error-- and it may even call close(entriesCh) multiple times (!!!).
move the chan creation + goroutine back to within the for loop.
There was a problem hiding this comment.
Oh yeah... I was wondering where we closed that
| @@ -159,7 +164,7 @@ func (m *mdnsService) handleEntry(e *mdns.ServiceEntry) { | |||
|
|
|||
| m.lk.Lock() | |||
| for _, n := range m.notifees { | |||
| n.HandlePeerFound(pi) | |||
| go n.HandlePeerFound(pi) | |||
There was a problem hiding this comment.
it looks like this is the only thing this changeset should change. (plus the logs)
whyrusleeping
force-pushed
the
feat/improve-mdns
branch
from
b1273e9
to
e6a5c5c
Compare
marten-seemann
added a commit
that referenced
this pull request
Dec 20, 2021
clean up dialer peerstore after each dial
marten-seemann
pushed a commit
that referenced
this pull request
Apr 21, 2022
return all dial errors if dial has failed
marten-seemann
pushed a commit
that referenced
this pull request
Apr 22, 2022
It _looks_ like the standard library doesn't always wrap this error. fixes #113
marten-seemann
added a commit
that referenced
this pull request
Apr 22, 2022
add support for wss dialing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code runs the
Connectcalls for each peer discovered over mdns in the same goroutine. If a connect call starts to hang, then it gums up the entire mdns discovery process.