Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the standard comment to deprecate basichost.Option and basichost.New #1134

Closed
wants to merge 1 commit into from
Closed

use the standard comment to deprecate basichost.Option and basichost.New #1134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions p2p/host/basic/basic_host.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ type AddrsFactory func([]ma.Multiaddr) []ma.Multiaddr

// Option is a type used to pass in options to the host.
//
// Deprecated in favor of HostOpts and NewHost.
// Deprecated: use HostOpts instead.
type Option int

// NATPortMap makes the host attempt to open port-mapping in NAT devices
Expand All @@ -67,7 +67,7 @@ type Option int
// port mappings periodically. The NATed addresses are included in the
// Host's Addrs() list.
//
// This option is deprecated in favor of HostOpts and NewHost.
// Deprecated: use HostOpts instead.
const NATPortMap Option = iota

// BasicHost is the basic implementation of the host.Host interface. This
Expand Down Expand Up @@ -336,7 +336,7 @@ func (h *BasicHost) updateLocalIpAddr() {
// * connmgr.ConnManager
// * madns.Resolver
//
// This function is deprecated in favor of NewHost and HostOpts.
// Deprecated: use NewHost instead.
func New(net network.Network, opts ...interface{}) *BasicHost {
hostopts := &HostOpts{}

Expand Down