use the standard comment to deprecate basichost.Option and basichost.New #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jul 22, 2021
|
And we should probably fix the tests... |
|
Actually, I change my mind. This is probably safe to get rid of. These have been deprecated for ages and nobody seems to use them. |
|
@marten-seemann : are we good to get the checks addressed so we can merge? |
|
@BigLep We'll abandon this PR, as @Stebalien suggested in #1134 (comment), and remove these functions. Will send a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been deprecated for a looong time (
Newsince 2017), but the deprecation comment was in a form that wouldn't get picked up by IDEs.Do we want to first rewrite the comment, and then remove this later, or should we do it right now?