This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
NoDial context option #42
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package net | ||
|
||
import ( | ||
"context" | ||
) | ||
|
||
type noDialCtxKey struct{} | ||
|
||
var noDial = noDialCtxKey{} | ||
|
||
// WithNoDial constructs a new context with an option that instructs the network | ||
// to not attempt a new dial when opening a stream. | ||
func WithNoDial(ctx context.Context, reason string) { | ||
context.WithValue(ctx, noDial, reason) | ||
} | ||
|
||
// GetNoDial returns true if the no dial option is set in the context. | ||
func GetNoDial(ctx context.Context) (nodial bool, reason string) { | ||
v := ctx.Value(noDial) | ||
if v != nil { | ||
return true, v.(string) | ||
} | ||
|
||
return false, "" | ||
} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, personally, I'd not expose the
NoDial
var but instead expose aGetNoDial(ctx) (nodial bool, why string)
function. That way, we can change how we implement all this internally.For example, we may want to "lift" all of our options into an option struct if we end up chaining contexts too much (searching for a value in a context is O(n)).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I mean, this just comes down to "patterns" but I believe this is the more common pattern.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.