This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
NoDial context option #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
This is an option to instruct the swarm not to dial when opening a new stream. Essential for (non-active) relays that should never attempt any dials in hop streams.
Stebalien
reviewed
Apr 10, 2019
|
|
||
| func WithNoDial(ctx context.Context, src string) { | ||
| context.WithValue(ctx, NoDial, src) | ||
| } |
There was a problem hiding this comment.
So, personally, I'd not expose the NoDial var but instead expose a GetNoDial(ctx) (nodial bool, why string) function. That way, we can change how we implement all this internally.
For example, we may want to "lift" all of our options into an option struct if we end up chaining contexts too much (searching for a value in a context is O(n)).
There was a problem hiding this comment.
(I mean, this just comes down to "patterns" but I believe this is the more common pattern.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an option to instruct the swarm not to dial when opening a new stream.
Essential for (non-active) relays that should never attempt any dials in hop streams.