This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
implement decaying tags. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Dec 27, 2019
Comment on lines
+145
to
+147
| if err := cm.decayer.Close(); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I think we should still cancel the background goroutine, even if this fails.
| // 1. Manages decay. | ||
| // 2. Applies score bumps. | ||
| // 3. Yields when closed. | ||
| func (d *decayer) process() { |
There was a problem hiding this comment.
A performance consideration here is that this loop might run way too often if the resolution is small.
There was a problem hiding this comment.
True, maybe we should introduce a hard lower limit for the resolution?
Closed
vyzo
approved these changes
Apr 20, 2020
Closed
2 tasks
yusefnapora
reviewed
May 11, 2020
We now allow the user to request tags at an interval lower than the decayer's resolution, and we override the effective interval to be the resolution. We also allow tags to have any interval, not necessarily a multiple of the resolution any longer.
yusefnapora
approved these changes
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on libp2p/go-libp2p-core#104. See that PR for an explanation.
Tests use mocked time. We need to use mocked time more often.
Fixes #47.