Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge Upstream v0.2.4 #22

Merged
merged 9 commits into from
Jul 30, 2020
Merged

merge Upstream v0.2.4 #22

merged 9 commits into from
Jul 30, 2020

Conversation

xiegeo
Copy link

@xiegeo xiegeo commented Jul 29, 2020

Upstream had breaking changes.

@xiegeo xiegeo requested a review from bonedaddy July 29, 2020 09:37
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #22 into master will decrease coverage by 4.72%.
The diff coverage is 82.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   93.60%   88.89%   -4.71%     
==========================================
  Files           1        3       +2     
  Lines         250      450     +200     
==========================================
+ Hits          234      400     +166     
- Misses         13       43      +30     
- Partials        3        7       +4     
Impacted Files Coverage Δ
connmgr.go 90.65% <65.86%> (-2.95%) ⬇️
decay.go 85.72% <85.72%> (ø)
options.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfee96...1c5b2c5. Read the comment docs.

Copy link

@bonedaddy bonedaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@xiegeo xiegeo merged commit 6418f67 into master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants