add notice about deprecation

lfoppiano · Apr 3, 2024 · 3c11c8a · 3c11c8a
1 parent be53b47
commit 3c11c8a
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/streamlit_pdf_viewer/__init__.py b/streamlit_pdf_viewer/__init__.py
@@ -25,9 +25,9 @@
     )
 
 
-def pdf_viewer(input: Union[str, Path, bytes], 
-               width: int = 700, 
-               height: int = None, 
+def pdf_viewer(input: Union[str, Path, bytes],
+               width: int = 700,
+               height: int = None,
                key=None,
                annotations: list = (),
                pages_vertical_spacing: int = 2,
@@ -70,9 +70,12 @@ def pdf_viewer(input: Union[str, Path, bytes],
             binary = fo.read()
     else:
         binary = input
-        
+
     if rendering == RENDERING_IFRAME or rendering == RENDERING_EMBED:
-        if height is None: 
+        console.warn(f"{RENDERING_IFRAME} and {RENDERING_EMBED} are deprecated. "
+                     f"They do not work consistently on all browswer "
+                     f"and will be removed in a future release.")
+        if height is None:
             height = "100%"
 
     base64_pdf = base64.b64encode(binary).decode('utf-8')