Fix action is_present field not being reset #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edwardalee, I believe it is correct now |
erlingrj
force-pushed
the
fix-action-present-bug
branch
from
777043b
to
4cfd1ce
Compare
lhstrh
reviewed
Sep 27, 2024
There was a problem hiding this comment.
Kudos for getting this fixed but I'll leave review to @edwardalee -- I can't quite follow the magic in the code generator...
edwardalee
approved these changes
Sep 28, 2024
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To correctly reset the
is_presentfield of actions we must add a pointer to thestatusfield of the associatedtrigger_tto theis_present_fieldsarray. This is because, for actions (unlike input ports), theis_presentfield is always overwritten by thestatusfield of thetrigger_tin the reaction preambles.UPDATE:
This exposed also an issue with the code-generated setup of the
is_present_fieldsarray for banks and multiport which is also fixed in this PRCorresponding reactor-c PR: lf-lang/reactor-c#482
Closing #2300 #2291