Python launch scripts #1914
Merged
Python launch scripts #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
edwardalee
approved these changes
Jul 25, 2023
|
For some reason the Python CI now runs much longer. Has anyone an idea why that could be? |
petervdonovan
approved these changes
Jul 25, 2023
lhstrh
reviewed
Jul 25, 2023
lhstrh
approved these changes
Jul 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the solution proposed in #1458 (comment). Instead of printing a Python command to run, we generate a shell or batch script in
bin/which can be executed to run the Python program. This ensures that the executing Python runtime is the same as the one we linked against during compilation.