-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update yarn installation instructions #469
Conversation
@Eschults implemented the recommendation in #464. But, I don't really have a good way of testing it. I did find @ElvisDot do you maybe have a burner system you could test this on hahah? No worries if no! I could also always try setting up a DigitalOcean droplet for a day and see if I can run our setup via SSH on Ubuntu, I guess....... |
…that is not necessary and does not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
Sorry Engineering's bandwidth is the same as in #464 (comment) 😕
No worries! But do we feel comfortable merging this without having at least tested it on Windows once? |
Let's ask in #teachers if someone is on Windows and would be so kind to run the two commands for us 😇 |
Ok will do! |
Hmmm so apparently it doesn't work with our node version on Ubuntu. I guess should we table merging this until we upgrade mode? |
Works on my machine. Did not test a lot just corepack enable and using yarn to install some package. |
It also seems like the issue on Natalia's computer was actually some kind of network error we haven't been able to solve yet. I do wonder if the same thing might happen to students, but it's also not necessarily a reason not to merge this |
I also think we don't use yarn at any point in the bootcamp anymore, so it wouldn't be a breaking problem if it didn't install on somebody's laptop |
👍 |
resolve #464