Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update radio field to use correct b4 classes for validation #159

Closed
wants to merge 1 commit into from

Conversation

calebsyring
Copy link
Contributor

@calebsyring calebsyring commented Sep 24, 2021

May fix #156 for the b4 template. Not meant to make a final decision on it. It was necessary to stop using label/input shorthand to get the bootstrap validation styling to work:

Due to constraints in how CSS works, we cannot (at present) apply styles to a <label> that comes before a form control in the DOM without the help of custom JavaScript.

https://getbootstrap.com/docs/4.6/components/forms/#how-it-works

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #159 (ff0dd18) into master (69003d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files          33       33           
  Lines        3385     3385           
=======================================
  Hits         3248     3248           
  Misses        137      137           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69003d3...ff0dd18. Read the comment docs.

@guruofgentoo
Copy link
Member

Incorporated these changes separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form template renders radio field inputs with same id
2 participants