Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ratelimits: Cleanup CheckRenewalExemptionAtWFE feature flag #7511

Open
5 tasks
Tracked by #5545
beautifulentropy opened this issue May 29, 2024 · 1 comment · May be fixed by #7680
Open
5 tasks
Tracked by #5545

ratelimits: Cleanup CheckRenewalExemptionAtWFE feature flag #7511

beautifulentropy opened this issue May 29, 2024 · 1 comment · May be fixed by #7680

Comments

@beautifulentropy
Copy link
Member

beautifulentropy commented May 29, 2024

Once we've deployed the changes in #7508 to all WFEs and RAs and set CheckRenewalExemptionAtWFE to true, we can rely on false isRenewal values to be authoritative in both the WFE and the RA.

  • Remove CheckRenewalExemptionAtWFE feature flag
  • Remove feature flag check inside of the WFE's NewOrder method
  • Remove feature flag check inside of the RA's checkNewOrderLimits method
  • Remove ra.SA.FQDNSetExists inside of the RA's checkNewOrdersPerAccountLimit method.
  • Remove ra.SA.FQDNSetExists inside of the RA's checkCertificatesPerNameLimit method.
ldlb9527 added a commit to ldlb9527/boulder that referenced this issue Aug 27, 2024
@ldlb9527 ldlb9527 linked a pull request Aug 27, 2024 that will close this issue
ldlb9527 added a commit to ldlb9527/boulder that referenced this issue Aug 27, 2024
@ldlb9527
Copy link

hi @beautifulentropy 👋 I'm working on resolving the issue related to removing the FQDNSetExists function. However, when I remove this function, the TestNewOrderRateLimiting and TestCheckFQDNSetRateLimitOverride test cases fail. Do you have any good suggestions for improving these test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants