Fix/catch any throwable bkp

src/Connectors/Consumer/Manager.php

@@ -2,14 +2,14 @@
 
 namespace Metamorphosis\Connectors\Consumer;
 
-use Exception;
 use Metamorphosis\Consumers\ConsumerInterface;
 use Metamorphosis\Exceptions\ResponseTimeoutException;
 use Metamorphosis\Exceptions\ResponseWarningException;
 use Metamorphosis\Middlewares\Handler\Dispatcher;
 use Metamorphosis\Record\ConsumerRecord;
 use Metamorphosis\TopicHandler\Consumer\Handler as ConsumerHandler;
 use RdKafka\Message;
+use Throwable;
 
 class Manager
 {
@@ -65,8 +65,8 @@ public function handleMessage(): void
             $this->consumerHandler->warning($exception);
 
             return;
-        } catch (Exception $exception) {
-            $this->consumerHandler->failed($exception);
+        } catch (Throwable $throwable) {
+            $this->consumerHandler->failed($throwable);
 
             return;
         }

src/TopicHandler/Consumer/AbstractHandler.php

@@ -2,9 +2,9 @@
 
 namespace Metamorphosis\TopicHandler\Consumer;
 
-use Exception;
 use Metamorphosis\Exceptions\ResponseWarningException;
 use Metamorphosis\TopicHandler\ConfigOptions\Consumer as ConsumerConfigOptions;
+use Throwable;
 
 abstract class AbstractHandler implements Handler
 {
@@ -29,7 +29,7 @@ public function warning(ResponseWarningException $exception): void
     /**
      * @phpcsSuppress SlevomatCodingStandard.Functions.UnusedParameter.UnusedParameter
      */
-    public function failed(Exception $exception): void
+    public function failed(Throwable $throwable): void
     {
     }
 

src/TopicHandler/Consumer/Handler.php

@@ -2,9 +2,9 @@
 
 namespace Metamorphosis\TopicHandler\Consumer;
 
-use Exception;
 use Metamorphosis\Exceptions\ResponseWarningException;
 use Metamorphosis\Record\RecordInterface;
+use Throwable;
 
 interface Handler
 {
@@ -26,5 +26,5 @@ public function finished(): void;
     /**
      * Handle failure process.
      */
-    public function failed(Exception $exception): void;
+    public function failed(Throwable $throwable): void;
 }

tests/Integration/Dummies/MessageConsumer.php

@@ -2,11 +2,11 @@
 
 namespace Tests\Integration\Dummies;
 
-use Exception;
 use Illuminate\Support\Facades\Log;
 use Metamorphosis\Exceptions\ResponseWarningException;
 use Metamorphosis\Record\RecordInterface;
 use Metamorphosis\TopicHandler\Consumer\AbstractHandler;
+use Throwable;
 
 class MessageConsumer extends AbstractHandler
 {
@@ -24,10 +24,10 @@ public function warning(ResponseWarningException $exception): void
         ]);
     }
 
-    public function failed(Exception $exception): void
+    public function failed(Throwable $throwable): void
     {
         Log::error('Failed to handle kafka record for sku.', [
-            'exception' => $exception,
+            'exception' => $throwable,
         ]);
     }
 }

tests/Unit/Connectors/Consumer/ManagerTest.php

@@ -1,8 +1,10 @@
 <?php
 
 namespace Tests\Unit\Connectors\Consumer;
 
+use Error;
 use Exception;
+use InvalidArgumentException;
 use Metamorphosis\Connectors\Consumer\Manager;
 use Metamorphosis\ConsumerConfigManager;
 use Metamorphosis\Consumers\ConsumerInterface;
@@ -15,10 +17,37 @@
 use RdKafka\Message as KafkaMessage;
 use Tests\LaravelTestCase;
 use Tests\Unit\Dummies\ConsumerHandlerDummy;
+use Throwable;
+use TypeError;
 
 class ManagerTest extends LaravelTestCase
 {
+
+    /**
+     * @dataProvider getThrowableScenarios
+     */
+    public function testShouldHandlerAnyThrowable(Throwable $throwable): void
+    {
+        // Set
+        $consumer = m::mock(ConsumerInterface::class);
+        $consumerHandler = m::mock(ConsumerHandler::class);
+        $dispatcher = m::mock(Dispatcher::class);
+
+        $runner = new Manager($consumer, $consumerHandler, $dispatcher, true, false);
+
+        // Expectations
+        $consumer->expects()
+            ->consume()
+            ->andThrow($throwable);
+
+        $consumerHandler->expects()
+            ->failed($throwable);
+
+        // Actions
+        $runner->handleMessage();
+    }
+
     public function testShouldHandleMultiplesMessages(): void
     {
         // Set
         $consumerRecord = $this->instance(
@@ -50,28 +79,24 @@
         $kafkaMessage3->payload = 'original message 3';
         $kafkaMessage3->err = RD_KAFKA_RESP_ERR_NO_ERROR;
 
-        $messages = [$kafkaMessage1, $kafkaMessage2, $kafkaMessage3];
-        $count = 0;
-        $exception = new Exception('Exception occurs when consuming.');
-
         // Expectations
         $consumer->shouldReceive('consume')
             ->times(4)
             ->andReturnUsing(
                 function () use ($messages, &$count, $exception) {
                     $message = $messages[$count] ?? null;
                     if (!$message) {
                         throw $exception;
                     }
                     $count++;
 
                     return $message;
                 }
             );
 
         $consumerHandler->expects()
             ->failed($exception);
-
+            
         $dispatcher->expects()
             ->handle($consumerRecord)
             ->times(3);
@@ -80,10 +105,9 @@
         $runner->handleMessage();
         $runner->handleMessage();
         $runner->handleMessage();
-        $runner->handleMessage();
     }
 
     public function testShouldCallWarningWhenErrorOccurs(): void
     {
         // Set
         $consumer = m::mock(ConsumerInterface::class);
@@ -114,7 +138,7 @@
 
         // Actions
         $runner->handleMessage();
     }
 
     public function testShouldHandleAsyncCommit(): void
     {
@@ -187,6 +211,23 @@
         $runner->handleMessage();
     }
 
+    public function getThrowableScenarios(): array
+    {
+        return [
+            'Exception' => [
+                'throwable' => new Exception(),
+            ],
+            'Error' => [
+                'throwable' => new Error(),
+            ],
+            'InvalidArgumentException' => [
+                'throwable' => new InvalidArgumentException(),
+            ],
+            'TypeError' => [
+                'throwable' => new TypeError(),
+            ],
+        ];
+
     protected function setUp(): void
     {
         parent::setUp();
@@ -203,5 +244,6 @@
             'middlewares' => [],
             'consumer_group' => 'consumer-id',
         ]);
+
     }
 }

tests/Unit/Dummies/ConsumerHandlerDummy.php

@@ -2,17 +2,17 @@
 
 namespace Tests\Unit\Dummies;
 
-use Exception;
 use Metamorphosis\Record\RecordInterface;
 use Metamorphosis\TopicHandler\Consumer\AbstractHandler;
+use Throwable;
 
 class ConsumerHandlerDummy extends AbstractHandler
 {
     public function handle(RecordInterface $data): void
     {
     }
 
-    public function failed(Exception $exception): void
+    public function failed(Throwable $throwable): void
     {
     }
 }