feat(styling): add styling methods #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add sx method to combine stylings resolves #20 Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
add makeStyles which exposes a useStyles hook with mergeDeep function resolves #20 Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
migrated the commitlint config file from javascript to typescript Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar
added
the
GSoC 2022
improved the mergeStyles function and made changes to the makeStyles accordingly resolves #20 Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
add the missing tests for makeStyles inside the utils Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
agentmilindu
requested changes
Jun 26, 2022
fix broken types and code for sx, mergeStyles and makeStyles BREAKING CHANGE: named argument pass for useStyles Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
add stories for makeStyles Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
add stories for sx Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers:
sxandmakeStylessxandmakeStylesresolves #20