Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test by default on linux, osx, win #793

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Conversation

leondz
Copy link
Owner

@leondz leondz commented Jul 18, 2024

Run tests on all supported OS platforms for each PR and any merge to main

To enable this all tests current tests need to support execution on CPU only systems, the following adjustments enable this support:

  • set atkgen red team model to cpu in DEFAULT_PARAMS
  • set atkgen red team model to float32 in DEFAULT_PARAMS
  • huggingface tests force to cpu
  • huggingface tests force to float32
  • ensure temp file is closed for cache test

@leondz
Copy link
Owner Author

leondz commented Jul 18, 2024

@jmartin-tech what's a good way of merging this?

@jmartin-tech
Copy link
Collaborator

Looks like there are some adjustments need to pass the test in github actions, we can add resolution to those to this PR and once passing this merge will be straight forward.

* set atkgen red team model to `cpu` in DEFAULT_PARAMS
* huggingface tests force to `cpu`

Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
* ensure temp file is closed for cache test
* set torch_dtype to `float32` as default in atkgen
* set torch_dtype to `float32` in huggingface tests

Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
@jmartin-tech jmartin-tech merged commit 27fb55d into main Jul 19, 2024
10 checks passed
@jmartin-tech jmartin-tech deleted the update/win_osx_default branch July 19, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants