Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert module-level constant names to uppercase #685

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

leondz
Copy link
Owner

@leondz leondz commented May 15, 2024

No description provided.

@leondz leondz requested a review from jmartin-tech May 15, 2024 19:08
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversion looks reasonable to me, is it possible to also give variables in tests the same treatment now to get consistent style throughout?

@leondz leondz merged commit 368c294 into main May 16, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@leondz leondz deleted the feature/constants branch May 29, 2024 07:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants