add some actionable opinions about linting #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consider adding an action that validates lint is passing for PRs as part of this branch. |
jmartin-tech
approved these changes
May 10, 2024
There was a problem hiding this comment.
Thank you for adding the action, just a minor suggestion noted.
This is a great place to start, I would love to see this action required to pass for open PRs in the near future. First we can let it bake and after a bit of tweaking the config or updating existing code it can be enabled as automation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project-specific lint preferences file. run with
pylint garak.resolves #11
(point three)