Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MANIFEST.in so all resources are installed #660

Merged
merged 3 commits into from
May 7, 2024

Conversation

JKL98ISR
Copy link
Contributor

@JKL98ISR JKL98ISR commented May 6, 2024

Currently when installing via the command:
pip install git+https://github.com/leondz/garak.git only some resources are downloaded. .i.e *.tsv resources are missing

… using pip with git

Currently when installing via the command:
`pip install git+https://github.com/leondz/garak.git`
only resources with .txt are downloaded

Signed-off-by: Jonathan Liberman <jonatan.lib@gmail.com>
Copy link
Contributor

github-actions bot commented May 6, 2024

DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅

@JKL98ISR JKL98ISR changed the title Update MANIFEST.in so all resources are installed also installed when… Update MANIFEST.in so all resources are installed May 6, 2024
@JKL98ISR
Copy link
Contributor Author

JKL98ISR commented May 6, 2024

I have read the DCO Document and I hereby sign the DCO

@leondz
Copy link
Owner

leondz commented May 6, 2024

thanks for the catch! will take a look

@jmartin-tech
Copy link
Collaborator

recheck

github-actions bot added a commit that referenced this pull request May 6, 2024
@leondz
Copy link
Owner

leondz commented May 7, 2024

made some refactoring changes - @JKL98ISR does this look good to you?

(base) 17:24:38 x1:~/dev/garak [main] $ gh pr checkout 660
Switched to branch 'patch-1'
(base) 17:24:52 x1:~/dev/garak [patch-1] $ flit build
Found 293 files tracked in git                                                                                                     I-flit.sdist
Built sdist: dist/garak-0.9.0.12.post1.tar.gz                                                                                 I-flit_core.sdist
Copying package file(s) from /tmp/tmpvqsdgzrn/garak-0.9.0.12.post1/garak                                                      I-flit_core.wheel
Writing metadata files                                                                                                        I-flit_core.wheel
Writing the record of files                                                                                                   I-flit_core.wheel
Built wheel: dist/garak-0.9.0.12.post1-py3-none-any.whl                                                                       I-flit_core.wheel
(base) 17:24:57 x1:~/dev/garak [patch-1] $ cd dist
(base) 17:24:58 x1:~/dev/garak/dist [patch-1] $ tar zxf garak-0.9.0.12.post1.tar.gz 
(base) 17:25:03 x1:~/dev/garak/dist [patch-1] $ cd garak-0.9.0.12.post1/
(base) 17:25:07 x1:~/dev/garak/dist/garak-0.9.0.12.post1 [patch-1] $ cd garak/
(base) 17:25:10 x1:~/dev/garak/dist/garak-0.9.0.12.post1/garak [patch-1] $ find . -name "*tsv"
./resources/book_cloze.tsv
./resources/nyt_cloze.tsv
./resources/guardian_cloze.tsv
./resources/book_cloze_80.tsv
./resources/misp_descriptions.tsv
(base) 17:25:14 x1:~/dev/garak/dist/garak-0.9.0.12.post1/garak [patch-1] $ 

@JKL98ISR
Copy link
Contributor Author

JKL98ISR commented May 7, 2024

Hi @leondz,
Yes it looks good
Thanks

@leondz leondz merged commit 6c14b11 into leondz:main May 7, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants