Enable parallel OpenAI calls #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
* ensure read and write of `reportfile` are in parent only * consolidate multiprocessing execution in `probes/base.py` Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
|
I did not test, only performed code review. But nothing here seems to remove or alter functionality in a breaking way. |
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
|
Extended refactor to provide example of using a base class that can share |
leondz
approved these changes
May 1, 2024
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #493
Conceptually since rest generator client objects should not retains state, this provides a pattern where
restgenerator client objects can be instantiated only when required and avoiding the need topicklethe client object when passing a generator to another process.OpenAI_config.transient.reportfileare in parent process onlyprobes/base.pyVerification testing preformed with:
Additional testing may be appropriate to validate changes to
baseandgcgprobe flows are not impacted.