Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate test file cleanup #634

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

jmartin-tech
Copy link
Collaborator

  • convert all log file cleanup to a finalizer
  • consolidate cleanup of run generated log files as global fixture

Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@leondz leondz merged commit 929699f into leondz:main Apr 29, 2024
4 checks passed
@leondz
Copy link
Owner

leondz commented Apr 29, 2024

excellent, this is much better

@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
@jmartin-tech jmartin-tech deleted the fix/more-test-file-cleanup branch May 2, 2024 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants